From 7b0fcc3690a7bbf9d30d5839917133052b3ffd34 Mon Sep 17 00:00:00 2001
From: fwx1246009 <fuzijian5@huawei.com>
Date: Fri, 5 May 2023 15:46:23 +0800
Subject: [PATCH] Add EXPECT_* checks for refbase and unique_fd.

Issue: I76TA9
Test: UT
Change-Id: Ie93adbd5eb32691f1634d147c72da7b76f983437
Signed-off-by: huangyuchen <huangyuchen3@huawei.com>
---
 base/test/unittest/common/utils_refbase_test.cpp | 10 +++++++++-
 .../unittest/common/utils_unique_fd_test.cpp     | 16 ++++------------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/base/test/unittest/common/utils_refbase_test.cpp b/base/test/unittest/common/utils_refbase_test.cpp
index a2a303d..e1ea6ea 100644
--- a/base/test/unittest/common/utils_refbase_test.cpp
+++ b/base/test/unittest/common/utils_refbase_test.cpp
@@ -1044,10 +1044,12 @@ HWTEST_F(UtilsRefbaseTest, testRefbaseDebug001, TestSize.Level1)
     sptr<RefBase> testObject1(new RefBase());
     testObject1->EnableTracker();
     sptr<RefBase> testObject2(testObject1);
+    EXPECT_EQ(testObject2->GetSptrRefCount(), 2);
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
     wptr<RefBase> testObject3(testObject2);
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
     wptr<RefBase> testObject4(testObject3);
+    EXPECT_EQ(testObject4->GetWptrRefCount(), 3);
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
 }
 
@@ -1061,10 +1063,12 @@ HWTEST_F(UtilsRefbaseTest, testRefbaseDebug002, TestSize.Level1)
     wptr<RefBase> testObject1(new RefBase());
     testObject1->EnableTracker();
     sptr<RefBase> testObject2 = testObject1.promote();
+    EXPECT_EQ(testObject2->GetSptrRefCount(), 1);
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
     wptr<RefBase> testObject3(testObject2);
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
     wptr<RefBase> testObject4(testObject3);
+    EXPECT_EQ(testObject4->GetWptrRefCount(), 3);
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
 }
 
@@ -1088,9 +1092,11 @@ HWTEST_F(UtilsRefbaseTest, testRefbaseDebug003, TestSize.Level1)
     sptr<TestDebug> testObject2(testObject1);
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
     sptr<TestDebug> testObject3;
+    EXPECT_EQ(testObject2->GetSptrRefCount(), 2);
     testObject3 = testObject2;
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
     wptr<TestDebug> testObject4(testObject3);
+    EXPECT_EQ(testObject4->GetWptrRefCount(), 4);
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
 }
 
@@ -1103,6 +1109,7 @@ HWTEST_F(UtilsRefbaseTest, testRefbaseDebug004, TestSize.Level1)
     sptr<TestDebug> testObject1(new TestDebug());
     std::thread subThread {[&testObject1]() {
         sptr<TestDebug> subTestObject1(testObject1);
+        EXPECT_EQ(testObject1->GetSptrRefCount(), 2);
         std::this_thread::sleep_for(std::chrono::milliseconds(1000));
         wptr<TestDebug> subTestObject2(subTestObject1);
         std::this_thread::sleep_for(std::chrono::milliseconds(1000));
@@ -1115,6 +1122,7 @@ HWTEST_F(UtilsRefbaseTest, testRefbaseDebug004, TestSize.Level1)
     wptr<TestDebug> testObject3(testObject2);
     std::this_thread::sleep_for(std::chrono::milliseconds(1000));
     subThread.join();
+    EXPECT_EQ(testObject3->GetWptrRefCount(), 2);
 }
 }  // namespace
-}  // namespace OHOS
\ No newline at end of file
+}  // namespace OHOS
diff --git a/base/test/unittest/common/utils_unique_fd_test.cpp b/base/test/unittest/common/utils_unique_fd_test.cpp
index 4734acc..3747ec7 100644
--- a/base/test/unittest/common/utils_unique_fd_test.cpp
+++ b/base/test/unittest/common/utils_unique_fd_test.cpp
@@ -53,11 +53,7 @@ void UtilsUniqueFd::TearDownTestCase(void)
     std::string testStr;
     inputfile >> testStr;
     inputfile.close();
-    if (remove(testfilename) == 0) {
-        ;
-    } else {
-        FAIL();
-    }
+    EXPECT_EQ(remove(testfilename), 0);
 }
 
 HWTEST_F(UtilsUniqueFd, testUtilsUniqueFd, TestSize.Level0)
@@ -65,18 +61,14 @@ HWTEST_F(UtilsUniqueFd, testUtilsUniqueFd, TestSize.Level0)
     int fd = open("NOTHISFILE", O_RDWR, 0666);
 
     UniqueFd ufd2(fd);
-    if (ufd2 == -1) {
-        SUCCEED();
-    }
+    EXPECT_EQ(ufd2, -1);
 };
 
 HWTEST_F(UtilsUniqueFd, testUtilsUniqueCtroFromInt, TestSize.Level0)
 {
 
     UniqueFd ufd2(open(testfilename, O_RDWR, 0666));
-    if (ufd2 == -1) {
-        FAIL();
-    }
+    EXPECT_NE(ufd2, -1);
 };
 
 HWTEST_F(UtilsUniqueFd, testUtilsUniqueFdeqcompare, TestSize.Level0)
@@ -167,4 +159,4 @@ HWTEST_F(UtilsUniqueFd, testUtilsUniqueFdDefineDeletorCloseStatus, TestSize.Leve
     ASSERT_EQ(ret, -1);
 };
 }  // namespace
-}  // namespace OHOS
\ No newline at end of file
+}  // namespace OHOS
-- 
Gitee